Repository navigation
Conversation
cyper98
requested review from
FGadvancer,
skiffer-git and
withchao
as code owners
November 8, 2026 09:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🅰 Please add the issue ID after "Fixes #"
Fixes #3827
Description
This PR fixes #3827 where
SetConversationscould insert new conversation documents for non-group members when handlingReadGroupChatTypeconversations with agroup_id.Root Cause
SetConversationsininternal/rpc/conversation/conversation.godid not validate thatUserIDswere actually members of the target group (group_member). When passed non-member user IDs,SetUsersConversationFieldTxcreated ghost session documents (sg_<groupID>) for users who were never in the group.Solution
req.Conversation != nilandlen(req.UserIDs) > 0.req.Conversation.GroupID/req.Conversation.ConversationIDif one of them is missing.ConversationType == constant.ReadGroupChatTypeandGroupIDis present, fetch the current group member IDs viac.groupClient.GetGroupMemberUserIDs(authverify.WithTempAdmin(ctx), req.Conversation.GroupID).req.UserIDsto the intersection with group members; log a warning for any ignored non-members.conversationNotificationSender.internal/rpc/conversation/conversation_test.gocovering all valid, invalid, and edge cases (all tests pass).